Implement thread safety when generating exceptions#3
Open
Implement thread safety when generating exceptions#3
Conversation
riegie
suggested changes
Feb 13, 2021
| result_dict[exception_name].append(results[i]) | ||
|
|
||
| for exception_name, results in result_dict.items(): | ||
| for i in range(len(results) - 1): |
Contributor
There was a problem hiding this comment.
@Cruuncher might be better to make this more pythonic and use enumerate instead:
for index, result in enumerate:
|
|
||
| for exception_name, results in result_dict.items(): | ||
| for i in range(len(results) - 1): | ||
| assert results[i] == results[i+1] No newline at end of file |
Contributor
There was a problem hiding this comment.
if you use enumerate, you can then just do:
assert result == results[index+1]
| import os | ||
| import pytest | ||
| import concurrent.futures | ||
| from random import shuffle |
| bound_parent = parent | ||
| acquired = update_mutex.acquire() | ||
| if not acquired: | ||
| raise Exception("Lock acquire while binding parent failed") |
Contributor
There was a problem hiding this comment.
not necessary to change but to make it more easy to to digest, perhaps:
raise Exception("Failed to acquire lock on GIL while binding parent")
|
|
||
| acquired = update_mutex.acquire() | ||
| if not acquired: | ||
| raise Exception("Lock acquire while generating exception failed") |
Contributor
There was a problem hiding this comment.
@Cruuncher same thing as above, just a suggestion for a more easy to understand exception message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.